Bug in vertical align action

Re: Bug in vertical align action

waltd — Sun, 24 Oct 2010 23:16:46 -500

Yes. THe issue is that internally, Freeway stores the styles applied to an element as a single string, rather than an object or some other key:value data structure. I have rewritten the get and set CSS functions slightly, my versions follow in a Gist.

Walter

On Oct 24, 2010, at 4:20 PM, pems wrote:

Hi everyone me again and as usual I know my question will sound a bit dim but here goes anyway. If I just want to add an extra style attribute to the page div is there a simple way to do it. I understand (and have successfully with a lot of help) added things using my actions within the HTML tags but I have never tackled adding extra style attributes. I have looked at the
       function GetCSSAttribute(tag, fieldName, attributeName)
within the manual and “my goodness” this looks like an enormous amount of code just to add 1 attribute, is this the only way? If someone could point out, what I need to use so I can add some extra style attributes or if there was a simple alternative then that would very handy

Pems :)

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

Re: Bug in vertical align action

pems — Sun, 24 Oct 2010 20:20:55 -500

Hi everyone
me again and as usual I know my question will sound a bit dim but here goes anyway. If I just want to add an extra style attribute to the page div is there a simple way to do it. I understand (and have successfully with a lot of help) added things using my actions within the HTML tags but I have never tackled adding extra style attributes. I have looked at the

        function GetCSSAttribute(tag, fieldName, attributeName)

within the manual and “my goodness” this looks like an enormous amount of code just to add 1 attribute, is this the only way?
If someone could point out, what I need to use so I can add some extra style attributes or if there was a simple alternative then that would very handy

Pems :)

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

Re: Bug in vertical align action

mmull — Thu, 09 Apr 2009 23:53:56 -500

Peter,

I have altered the css navigation action to be found here:

http://www.freewaytalk.net/thread/view/50746

All I did was comment the offending line and everything works now, must try and find out what the previous code did to the body tag to screw everything up though.

regards,

mmull

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

Re: Bug in vertical align action

mmull — Tue, 17 Mar 2009 22:44:30 -500

Peter,

Grab this file and see what happens:

http://mmuller.vndv.com/css-va.zip

If you remove the css menus action it centres vertically.

If you remove the vertical align action the menu works.

The error is from the css menus action, so not sure if there is anything you can do to fix this unfortunately…

Best Regards,

mmull

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

Re: Bug in vertical align action

Peter Gutbrod — Fri, 13 Mar 2009 10:39:16 -500

@DeltaDave:

Nice to here someone is actually using my patch.

Thanks for pointing out the missing slash. The formatter had eaten it up unfortunately. ;-)

@mmull:

I’d bet, the error appears also in the original vertical-align action. Right?

You can send me a to a single page stripped down Freeway document, where the error occurs, and I can have a look, when I have time. But no promise that I can fix it.

Peter

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

Re: Bug in vertical align action

mmull — Wed, 11 Mar 2009 20:43:26 -500

Edit to the above…

the error and code appear in the css menus action that ships with Freeway, is there a way to get around this do you think ?

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

Re: Bug in vertical align action

mmull — Wed, 11 Mar 2009 20:41:12 -500

One small caveat to using this is it breaks the page body tags and therefore if you try to use ‘css menus’ on a vertically centred page the app errors with the following message:

“bodyTag has no properties”

and highlights this line:

fwParameters.bodyTag.fwValue = bodyTag[0];

any help would be greatly appreciated

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

Re: Bug in vertical align action

DeltaDave — Wed, 11 Mar 2009 00:08:23 -500

I have just done a small update to a site last fiddled with in FW4 and couldn’t understand why some of my Vertically Aligned pages were giving me grief. Until I found this thread of course and Peter’s version has done the trick for me.

But be careful as the last line

<page-action>

should read

</ page-action>

But with no space between the ‘/’ and ‘page-action’

The Web forum does muck with this.

Maybe this could be added to Actions Forge Peter.

David

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

Re: Bug in vertical align action

waltd — Thu, 11 Sep 2008 12:51:37 -500

The formatter does its best, but for something this long and involved, you might want to use Pastie: http://pastie.org

Walter

On Sep 11, 2008, at 8:30 AM, Peter Gutbrod wrote:

Hmm, the parser seems to have its problems, even with the 4 spaces thing.

Peter

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

Re: Bug in vertical align action

Peter Gutbrod — Thu, 11 Sep 2008 12:30:53 -500

Hmm, the parser seems to have its problems, even with the 4 spaces thing.

Peter

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options

Bug in vertical align action

Peter Gutbrod — Tue, 09 Sep 2008 11:08:49 -500

I found a bug in the vertical align action, when used together with horizontal page centering:

It tries to remove the “height” parameter from the pageDiv tag to work with Safari. But the pageDiv tag in my FW 5 output has only a “min-height” parameter. That leaves to an invalid “min-” parameter.

I simply commented out the following line in the action:

// pageDiv.style = RemoveStyleParameter(pageDiv.style,”height”); // Height stuffs up Safari (applied if page horizontally aligned as well)…

Now it works together with center page aligning. The min-height parameter doesn’t seem to stuff up Safari.

There is still an issue with layered item. To do proper vertical aligning it needs at least one non layered item at the bottom of the layout. What it does is to place a table within the PageDiv tag thus preventing the height of the PageDiv to collapse.

To work on layered items without the help of this non-layered item, the min-height parameter of the PageDiv tag has to be replaced with the height parameter set to the absolute height of the PageDiv.

To calculate the height of the PageDiv currently I only can iterate through all div tags enclosed by the PageDiv to look for the top and height parameters. If anyone knows an easier way to calculate the height, please drop a line.

Peter

actionsdev mailing list email@hidden Update your subscriptions at: http://freewaytalk.net/person/options